build_pdf tends to crop bottom of slide? #16

Activity

1. jhelvy commented on Feb 24, 2021

   

   jhelvy

   on Feb 24, 2021

   Last edited by jhelvy

   Owner

   More actions

   Hmm, I've tried two ways to build a pdf from your slides, but both ways cut off the bottom charts:

   input <- "https://mattansb.github.io/bayesian-evidence-iscop-2021/index.html"
   build_pdf(input)
   build_pdf(input, complex_slides = TRUE)

   The first approach relies on pagedown::chrome_print(). The second uses the {chromote} package, but in the end also prints from Chrome. So I think this may just be an issue with how Chrome prints pages to pdfs.

   Edit: The above code will only work with v. 0.0.5, which I just pushed. I realized I hadn't enabled some of the build functions to build directly from slides on a website, but that now should be enabled.
2. mattansb commented on Feb 25, 2021

   

   mattansb

   on Feb 25, 2021

   Author

   More actions

   So I think this may just be an issue with how Chrome prints pages to pdfs.

   I'm not sure about that - attached is a print from chrome which does have the last graph: test.pdf
3. jhelvy commented on Feb 25, 2021

   

   jhelvy

   on Feb 25, 2021

   Owner

   More actions

   How did you print that? I just opened the slides in Chrome on my machine and printed them directly from Chrome, and I got the same crop problem. If you're able to print it without the crop there must be a solution, maybe a setting that can be tweaked.
4. mattansb commented on Feb 25, 2021

   

   mattansb

   on Feb 25, 2021

   Author

   More actions

   I did the same - opened the slide in chrome (win10) and ctrl+p as pdf...
5. jhelvy commented on Feb 25, 2021

   

   jhelvy

   on Feb 25, 2021

   Owner

   More actions

   Interesting...I'm on a mac, but I wouldn't expect that to be the root cause. It's particularly odd that you get a difference between using "Open Chrome -> ctrl + p" compared to pagedown::chrome_print() since those should be the same thing. I feel like there might be a different print setting in the "Open Chrome -> ctrl + p" method that is not used with pagedown::chrome_print()
6. mattansb commented on Feb 25, 2021

   

   mattansb

   on Feb 25, 2021

   Author

   More actions

   This is what I get:

   
7. jhelvy commented on Feb 25, 2021

   

   jhelvy

   on Feb 25, 2021

   Owner

   More actions

   Okay so it looks like it might be an issue with the margin settings.

   On my machine, the default margins crop the slide:

   

   But if I set the margins to "minimum" and include headers and footers, it doesn't crop the charts, though is still looks like it crops a tiny amount on the bottom since the slide number is chopped a bit:

   

   I still can't find a setting on my end that looks like yours, but this is promising as I can probably change the print settings from pagedown::chrome_print().
8. mattansb commented on Feb 25, 2021

   

   mattansb

   on Feb 25, 2021

   Author

   More actions

   Awesome (:
9. jhelvy

   added

   bugSomething isn't workingSomething isn't working

   on Apr 20, 2021