Repository navigation
Move the project to the jonoffcpu organization - #25
Merged
Merged
Conversation
The repository now lives at jonoffcpu/jonoffcpu, so the Maven group and the Java packages move from io.github.lhotari to io.github.jonoffcpu, the namespace the Central Portal verifies against the jonoffcpu GitHub organization. The sources move to io/github/jonoffcpu, and the proto packages, the shading relocations, the JNI symbols and class lookups, the Rust protobuf bindings, the proof tools and the agent's system properties follow. The POM's project and SCM URLs, the README's links, the release workflow's README version pattern and the documentation point at jonoffcpu/jonoffcpu. The async-profiler submodule now tracks the jonoffcpu-dev branch of the jonoffcpu/async-profiler fork, pinned to its head, which differs from the previous pin only in the fork's README. The architecture diagram names the jonoffcpu fork and is rendered again. The Java packages, the agent's system property names and the Maven coordinates change; the capture, report and profile formats do not, since protobuf field numbers are unaffected.
lhotari
added
the
maintenance
The move to io.github.jonoffcpu turned io.github.lhotari.jonoffcpu into io.github.jonoffcpu.jonoffcpu. The organization already names the project, so the packages become io.github.jonoffcpu.agent, .capture, .offline and .profile, and the sources move up one directory. The proto packages, shading relocations, JNI symbols, Rust bindings, proof tools and documentation follow, and the agent's system properties become io.github.jonoffcpu.nativeLibc and io.github.jonoffcpu.nativeWorkDir.
Nothing lives directly in io.github.jonoffcpu any more; each package
names its component:
- io.github.jonoffcpu.agent: the agent, whose relocated dependencies
move from io.github.jonoffcpu.internal.shaded to
io.github.jonoffcpu.agent.internal.shaded and whose system properties
become io.github.jonoffcpu.agent.nativeLibc and .nativeWorkDir.
- io.github.jonoffcpu.capture: the capture stream's framing and codec.
- io.github.jonoffcpu.codec: ProtoJson, the one JSON printer and parser
of every message, which is not specific to the capture stream.
- io.github.jonoffcpu.correlator: the correlator, formerly
io.github.jonoffcpu.offline, with its profile codec in .profile, its
packaging tests in .packaging and its presets under
io/github/jonoffcpu/correlator/presets.
The correlator's proto schemas follow as
io.github.jonoffcpu.correlator.{analysis,report,signals,profile}.v1; the
agent's and the capture stream's keep their names. Protobuf field
numbers and the JSON mapping are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repository now lives at
jonoffcpu/jonoffcpu. This PR moves every reference to the new organization and names each Java package after the component that owns it.Maven group and Java packages
The Maven group changes from
io.github.lhotaritoio.github.jonoffcpu. Nothing lives directly inio.github.jonoffcpu; each package belongs to a component:io.github.jonoffcpu.agent.agent.internal.shadedio.github.lhotari.jonoffcpu.agentio.github.jonoffcpu.captureio.github.lhotari.jonoffcpu.captureio.github.jonoffcpu.codecProtoJson, the one JSON printer and parser for every messageio.github.lhotari.jonoffcpu.captureio.github.jonoffcpu.correlator.profile,.packaging(tests) and…/correlator/presetsio.github.lhotari.jonoffcpu.offline/.profileThe move covers:
FindClasslookups in the C bridge, and the Rust protobuf bindings.MANIFEST.MF.java_packageoptions.The correlator's proto schema packages become
io.github.jonoffcpu.correlator.{analysis,report,signals,profile}.v1. The agent's and the capture stream's schema packages areio.github.jonoffcpu.agent.v1andio.github.jonoffcpu.capture.v1.Repository references
lhotari/jonoffcpubecomesjonoffcpu/jonoffcpuin:ghcommandsThe POM's developer entry is unchanged.
async-profiler submodule
The submodule now tracks
jonoffcpu-devofjonoffcpu/async-profiler, pinned to its head96575c0. That commit differs from the previous pin only in the fork's README.AGENTS.md,README.mdand the architecture diagram name the new fork, and the diagram is rendered again.Compatibility
io.github.jonoffcpu:jonoffcpu-*SignalCaptureAgent.start()/stop()-Dio.github.jonoffcpu.agent.nativeLibcand-Dio.github.jonoffcpu.agent.nativeWorkDirio.github.jonoffcpu:…:0.5.0, which starts resolving with the next release. The release workflow then updates the version numbers.Before the next release
io.github.jonoffcpunamespace in the Sonatype Central Portal.Verification
./gradlew :jonoffcpu-agent:check :jonoffcpu-correlator:checkpasses on an arm64 Mac: 308 tests, 0 failures. That includes:spotlessApplyandcargo fmt --checkare clean.