Repository navigation
Lead the digest with busy time and take its idle patterns in correlate - #30
Merged
Merged
Conversation
The digest ranked busy and idle time side by side, and it knew idle waits only through preset:jvm-idle. An application's own idle waits, such as BookKeeper's task queues in a Pulsar broker, therefore filled its busy tables: 87 % of one broker's "busy" time was a worker waiting for a task, and the idle table beside it listed waits nobody needs. correlate now takes --idle and --idle-from (default preset:jvm-idle) for the digest alone; the collapsed stacks, the profile and the report keep every interval. The digest is about busy time: where the time went leads with it, idle intervals are counted there and left out of every table and stack, and the Markdown names the idle patterns and the top command that lists the waits it left out. The idle table is removed from the Digest message, its field reserved. summarize writes the same layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The digest (
jonoffcpu-summary.md/.json) wasn't useful on its own:preset:jvm-idle, so an application's own idle waits landed in the busy tables. On an Apache Pulsar broker capture, 87 % of the digest's "busy" time was BookKeeper workers waiting for a task (GrowableBatchedArrayBlockingQueue.takeAll).This PR makes the digest the idle-filtered summary.
correlate --idle REGEX/--idle-from FILE(defaultpreset:jvm-idle) set the idle patterns for the digest alone.--summary-output false, and these options in partial mode.topcommand that lists the idle waits.summarizewrites the same layout, and its help and the shared--idledescription say what idle now means for the digest.On that broker capture, with
--idle-frompointing at the harness's idle list (the preset plus BookKeeper's…BlockingQueue.take(All)), busy time comes to 43.371 s. That matches the harness's own idle-filtered flame graph, and the busy table now ranks thread start, monitor and lock contention.Compatibility
jonoffcpu-summary.json:Digest.idle(field 10) is removed andreserved. The idle totals remain inwhereTheTimeWent.Verification
./gradlew spotlessCheck :jonoffcpu-agent:check :jonoffcpu-correlator:check :jonoffcpu-jfr-converter:check :jonoffcpu-capture-codec:checkpasses: 302 tests, 0 failures.correlate --idle-fromwith a pattern matching every frame leaves no busy time in the digest.--idleis rejected with--summary-output falseand in partial mode.correlate,summarize,topand the root command are regenerated. The README option table is checked byreadmeTest.