Repository navigation
Read stacks filter patterns from files - #6
Merged
Merged
Conversation
lhotari
added this pull request to stack #7
September 23, 2026 16:25
stacks gains --include-from FILE and --exclude-from FILE, so a maintained
list of patterns, such as a service's idle waits, can be kept in a file
instead of repeated on every command line. Both repeat, and their patterns
are added after any given with --include/--exclude; the filter rules are
unchanged.
A file holds one regular expression per line, read as UTF-8. Blank lines and
lines starting with '#' are skipped ('\#' escapes a pattern that starts with
'#'), and every other line is taken verbatim, spaces included, since frame
names such as "C2 Runtime complete_monitor_locking" contain them. A file
with no patterns is refused rather than read as no filter, which for an
include would keep everything, and an invalid pattern is reported with its
file and line. The --summary file lists the patterns read.
lhotari
force-pushed
the
stacks-filter-files
branch
from
September 23, 2026 16:33
bb24b1c to
94d9477
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5: this PR's base is
stacks-native-frames, so its diff shows only this change. Retarget it tomainonce that PR merges.Change
stacksgains--include-from FILEand--exclude-from FILE, so a list of patterns you maintain, such as a service's idle waits, can live in a file instead of being repeated on every command line.--include/--exclude. The filter rules are unchanged: any matching pattern counts, and an exclude beats an include.#are skipped.\#escapes a pattern that starts with#.C2 Runtime complete_monitor_lockingcontain spaces.--summaryfile lists the patterns read.The usage text, README §5 (with an
--exclude-fromexample) andOFFLINE.mdare updated.Verification
./gradlew spotlessCheck :jonoffcpu-correlator:checkpasses. New cases inStackProfileTest.filters:--include;\#is kept;