Skip to content

Core: Remove private copies of push, sort & splice from the jQuery prototype - #4473

Merged
mgol merged 1 commit into
jquery:masterfrom
mgol:push-sort-splice
Sep 24, 2019
Merged

mgol merged 1 commit into
jquery:masterfrom
mgol:push-sort-splice

Conversation

@mgol

@mgol mgol commented Aug 29, 2019

Copy link
Copy Markdown
Member

Summary

Remove private copies of push, sort & splice from the jQuery prototype. Saves 13 bytes.

Checklist

@mgol mgol added this to the 4.0.0 milestone Aug 29, 2019
@mgol mgol self-assigned this Aug 29, 2019

@timmywil timmywil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 4.0

@mgol
mgol force-pushed the push-sort-splice branch from 44613bb to 815d8f5 Compare August 30, 2019 23:53
@mgol
mgol merged commit b59107f into jquery:master Sep 24, 2019
@mgol
mgol deleted the push-sort-splice branch September 24, 2019 00:12
@mgol mgol removed the Needs review label Sep 24, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants