Skip to content

ImageRequest userInfo dictionary Any type for value allows unsupported types for imageIdKey  #772

Description

@sean-escendant

My project is using signed URLs for images and Nuke 12.4. I followed the documentation to use a custom image id key. Initially I had passed a URL, with query parameters stripped, as the custom key but testing showed that the cache wasn't working as expected. Only when I changed the key to a String, as in the documentation example, it started working as expected.

It seems some trade offs were made in the API design from Nuke 9 to 10 which introduced this, hopefully you can find a way to keep the API strongly typed otherwise a clear notice in the documentation as to what are the supported types for imageIdKey.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    improvementNon-functional change that improves existing functionality

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions