Repository navigation
Don't store image previews in the disk cache - #885
Merged
Merged
Conversation
storeCachedImage documented that previews are not stored, but the disk branch had no isPreview check, so a progressive scan could be written under the final image key. Match the pipeline invariant in TaskLoadImage and skip previews on the disk path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImagePipeline.Cache.storeCachedImagedocumented that previews are not stored, but the disk branch had noisPreviewcheck. An app passing the latest progressiveImageContainerwould write a half-decoded scan into the data cache under the final image key, and it would be served back as the completed image on the next load.The disk branch now skips previews, matching the invariant
TaskLoadImage.shouldStoreResponseInDataCachealready enforces. Memory-cache behavior is unchanged (still governed byisStoringPreviewsInMemoryCache). Doc comment updated to describe the real contract, plus tests covering both layers.