Repository navigation
Fix Resize crop path ignoring upscale: false - #886
Merged
Merged
Conversation
The crop path never forwarded `upscale` to `byResizingAndCropping`, so an image smaller than the target was always enlarged. It's now cropped to the target aspect ratio at its native resolution instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageProcessors.Resizenever forwardedupscaletobyResizingAndCropping, socrop: truealways enlarged images smaller than the target (contradicting the docs), and produced two cache entries with identical content forupscale: true/false.upscaleis now forwarded and honored: withupscale: falsethe image is cropped to the target aspect ratio at its native resolution instead of being enlarged. Downscaling andupscale: trueare unchanged.Adds coverage in
ResizeTests.