Repository navigation
Compare URL schemes case-insensitively in isLocalResource - #887
Merged
Merged
Conversation
URI schemes are case-insensitive (RFC 3986), so URLs like FILE:// or Data: were not recognized as local resources: they went through the data loader and their bytes were duplicated into the disk cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL.isLocalResourcecomparedschemeagainst "file"/"data" with==, but URI schemes are case-insensitive (RFC 3986). URLs such asFILE://…orData:…were therefore treated as remote: they were loaded through the data loader instead of read directly, and their bytes were duplicated intoDataCache.The comparison is now case-insensitive. Adds unit tests for
isLocalResourceand pipeline tests asserting thatFILE://andDATA:URLs skip the data loader and are not written to the disk cache.