Repository navigation
Fix GIF previews bypassing the preview policy - #892
Merged
Merged
Conversation
The GIF branch in `decodePartiallyDownloadedData` ran before the `previewPolicy` switch, so a delegate returning `.disabled` still got a full decode and an emitted preview for every partially downloaded GIF, contradicting the documented "no previews are generated for partially downloaded data". `.disabled` is now checked first and covers GIFs. The other policies keep the existing one-shot GIF preview, since GIFs can't be decoded incrementally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GIF branch in
decodePartiallyDownloadedDataran before thepreviewPolicyswitch, so a delegate returning.disabled— documented as "No previews are generated for partially downloaded data" — still got a fullUIImage(data:)decode and an emitted preview for every partially downloaded GIF..disabledis now checked first and applies to GIFs too..incrementaland.thumbnailkeep the existing behaviour: GIFs can't be decoded incrementally, so a single preview is generated from whatever has been downloaded so far. The default policy for GIF data is.incremental, so nothing changes unless a delegate opts out.