Repository navigation
Forward didCreateTask to the delegate on macOS and Mac Catalyst - #895
Merged
Merged
Conversation
The method was wrapped in a platform check added back when the macOS SDK didn't declare it; the runtime `#available` check is enough now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataLoader.delegatenever receivedurlSession(_:didCreateTask:)on macOS or Mac Catalyst, so proxy delegates like Pulse'sURLSessionProxyDelegatesaw every other callback but no task-creation events there. The forwarding method was wrapped in#if !os(macOS) && !targetEnvironment(macCatalyst), added years ago when the macOS SDK didn't declare the delegate method; it has existed since macOS 13, and the method's own runtime#availablecheck already covers the macOS 12 deployment target.