Repository navigation
Preserve image opacity in GaussianBlur - #896
Merged
Merged
Conversation
The scratch vImage contexts always used .premultipliedLast, so blurring an opaque photo tagged the output with an alpha channel and ImageEncoders.Default encoded it as PNG instead of JPEG/HEIC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blurring an opaque photo used to produce an image tagged with an alpha channel, which made
ImageEncoders.Defaultencode it as PNG instead of JPEG/HEIC and silently bypassisHEIFPreferred, so cached entries under.storeEncodedImageswere multiple times larger than they needed to be. The scratch contextsvImageBoxConvolve_ARGB8888renders into were always created with.premultipliedLast; they now use.noneSkipLastfor opaque sources, keeping the 32-bit layout vImage requires while images with an actual alpha channel keep being blurred as before.