Repository navigation
fix(gh-view): preserve reviewer fields in _attachLocalStatus and guard Changes Requested (Resolved) - #124
Merged
Conversation
…d Changes Requested (Resolved) - Copy `reviewAuthors`, `approvedReviewers`, `lastAuthorReviewAt`, `lastCommitAt`, and `lastUnrequestedReviewAt` when `_attachLocalStatus` constructs the enriched `GhPr` instance in `runGhView`. - Require `hasAuthorRespondedSinceLastReview` before classifying `CHANGES_REQUESTED` with `areThreadsResolved` as `Changes Requested (Resolved)` / `Re-review Needed (threads resolved)`, so top-level `CHANGES_REQUESTED` reviews on PRs with older resolved bot threads (e.g. `flutter/flutter#192965`) remain `🔴 Changes Requested (@Reviewer)`. - Set `maxPageSize: 15` in `fetchOpenPullRequests` to avoid GitHub GraphQL `HTTP 502` gateway timeouts on dense PR pages.
📊 Cognitive Complexity AnalysisNet Delta: +2 | Added: 0 | Increased: 2 | Improved: 0 | Violations: 0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reviewAuthors,approvedReviewers,lastAuthorReviewAt,lastCommitAt, andlastUnrequestedReviewAtwhen_attachLocalStatusconstructs the enrichedGhPrinstance inrunGhView.hasAuthorRespondedSinceLastReviewbefore classifyingCHANGES_REQUESTEDwithareThreadsResolvedasChanges Requested (Resolved)/Re-review Needed (threads resolved), so top-levelCHANGES_REQUESTEDreviews on PRs with older resolved bot threads (e.g.flutter/flutter#192965) remain🔴 Changes Requested (@reviewer).maxPageSize: 15infetchOpenPullRequeststo avoid GitHub GraphQLHTTP 502gateway timeouts on dense PR pages.