This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Repository navigation
Adding doc to change the actual broker - #192
Merged
knative-prow-robot merged 1 commit intoApr 17, 2020
Merged
Conversation
Signed-off-by: Matthias Wessendorf <[email protected]>
Member
Author
|
/assign @aliok |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mattmoor
reviewed
Apr 17, 2020
mattmoor
left a comment
mattmoor
left a comment
Member
There was a problem hiding this comment.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
Comment on lines
+52
to
+53
| By default the `ChannelBasedBroker` broker will be used, but you can change that by providing | ||
| a different `defaultBrokerClass` in the custom resource, like: |
Member
There was a problem hiding this comment.
Format markdown:
Suggested change
| By default the `ChannelBasedBroker` broker will be used, but you can change that by providing | |
| a different `defaultBrokerClass` in the custom resource, like: | |
| By default the `ChannelBasedBroker` broker will be used, but you can change that | |
| by providing a different `defaultBrokerClass` in the custom resource, like: |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
defaultBrokerClass