Repository navigation
Support for imagePullSecrets #124
Description
Activity
I'm running into this today... so +1 to supporting private registries that require a PullSecret.
from the slack chat about this:
the pods in knative-serving namespace are using the "controller" service account. In order for the images to be pulled, that SA needs a imagePullSecret with the creds for the private registry hosting the images - assuming you're using a private registry. However, processing the default serving.yaml, it creates the SA and the Pods all in one shot, not giving anyone a chance to inject the SA with the imagePullSecret. Do I have all of this right? And if so, is there any way to get around this situation w/o modifying the yaml or splitting it up in some way?
/cc @houshengbo
Do we have anyone working on this yet? Otherwise, I might take a swing at it.
Nope, feel free to take it. Thanks!
/assign phamill
@trshafer: GitHub didn't allow me to assign the following users: phamill.
Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guideDetails
In response to this:
/assign phamill
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/assign phamill
/assign garron
/unassign phamill
- added a commit that references this issue
on Sep 16, 2019
knative by default does not ship with imagePullSecrets because the registry is put on gcr.io/knative-releases by default. However by supporting custom registries, the operator should also support imagePullSecrets.
https://kubernetes.io/docs/concepts/containers/images/#referring-to-an-imagepullsecrets-on-a-pod
Proposal: