Repository navigation
[13.x] Fix examples and descriptions that don't match framework behavior - #11387
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few examples and descriptions in the docs don't match the behavior of Laravel 13.x. I checked each case against the framework.
In
validation.md, the comment forPassword::min(8)->uncompromised(3)says the password must have appeared less than 3 times.NotPwnedVerifieronly fails when the count is greater than the threshold, so a password seen exactly 3 times still passes.The online index example in
migrations.mdalso doesn't produce the result shown. Chaining->online()after->unique()on the column definition doesn't add theCONCURRENTLYflag. Applyingonline()to the index definition does:In
pagination.md, theUser::paginate()JSON example includescurrent_page_url, butLengthAwarePaginator::toArray()doesn't return that key. That key is present on the simplePaginatorinstead.Finally,
requests.mdsays thatinteger()uses the default when the cast fails. The method uses a plain(int)cast, so a non-numeric value becomes0; the default is only used when the input is missing.These examples and descriptions are updated to match the actual 13.x behavior.