Skip to content

[13.x] Fix incorrect values in descriptions and examples - #11388

Merged
taylorotwell merged 1 commit into
laravel:13.xfrom
GabeSilvaDev:fix/incorrect-values-in-prose
Oct 1, 2026
Merged

taylorotwell merged 1 commit into
laravel:13.xfrom
GabeSilvaDev:fix/incorrect-values-in-prose

Conversation

@GabeSilvaDev

Copy link
Copy Markdown
Contributor

A few values and descriptions in the docs don't match what Laravel 13.x actually uses.

The HTTP client comments describe server errors as >500 and client errors as >400 and <500, but serverError() checks for >= 500 and clientError() checks for >= 400 && < 500. This means 500 and 400 responses are included.

The cache.headers section says the etag directive generates an MD5 hash of the content. SetCacheHeaders uses hash('xxh128', ...) instead, so the ETag for hello is b5e9c1ad071b3e7fc779cfaa5e523818, not its MD5.

The custom session handler documentation describes $lifetime passed to gc() as a UNIX timestamp. It is actually the session lifetime in seconds, which is subtracted from the current time by both the file and database handlers.

The DynamoDB batch pruning example uses QUEUE_FAILED_DRIVER for the batching driver, while the example above it and the default configuration use QUEUE_BATCHING_DRIVER.

Finally, the dev command table still shows php artisan serve --host=localhost. Since laravel/framework#61090, the server process is simply php artisan serve.

These values and descriptions are updated to match the 13.x implementation.

Copilot AI balanced review requested due to automatic review settings October 1, 2026 02:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@taylorotwell
taylorotwell merged commit 2b66ce0 into laravel:13.x Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants