Patrol is built into a release app, even when it is a dev_dependency

@mateuszwojtczak

That's what Apple sent us after we released an app using patrol v0.10.2 on Test Flight.

This is the line which is causing this warning.

It also hints at a much bigger problem – Patrol's native code is built into an app binary in release mode, which increases its size. I haven't done any benchmarks, but gRPC which we're using isn't known for being lightweight...

cc @mateuszwojtczak

Related issues:

Strip plugins created from dev_dependencies from release-mode apps flutter/flutter#56591
Plugins with iOS native code included as dev_dependencies are being embedded in Release version of the app flutter/flutter#49101
Don't include dev_dependencies in native build scripts flutter/flutter#45714
integration_test embedded in shipping iOS apps when added to pubspec flutter/flutter#74274

(Android) Verify that Patrol's code is built into the app

Build the app (debug mode, release mode - shouldn't matter. We're a dev_dependency, so we shouldn't be included anyway).
```
$ flutter build apk
```

Use apkanalyzer to see that Patrol's code is included in the resulting dex:

# run in the directory with app's pubspec.yaml
$ apkanalyzer -h dex packages build/app/outputs/flutter-apk/app-debug.apk | grep pl.leancode.patrol | wc -l

In my case, it prints 5112, but it should be 0 instead.

The same can be done for other dev_dependencies that shouldn't land in the app binary, but they do, e.g. integration_test:

$ apkanalyzer -h dex packages build/app/outputs/flutter-apk/app-debug.apk | grep integration_test | wc -l
     344

@bartekpacia

Got the same issue @bartekpacia. Looking forward to a fix, although it is not stopping us as we dropped back to 0.9.1 for now.

@KonAtPropertyMe

@KonAtPropertyMe I'm working on a fix (or rather a nicer workaround, because the root cause lies in Flutter itself)

For the time being, you can update to the newest Patrol (v0.10.5) and use the below script (made by @jarekb123) to remove dependency on patrol in your CI:

# This script is run before fastlane build (mainly iOS build)
#
# It's a workaround for Apple app rejection: 
# ITMS-90338: Non-public API usage - The app references non-public selectors in Frameworks/patrol.framework/patrol: terminate.

cp pubspec.yaml pubspec_copy.yaml
sed '/patrol/d' pubspec_copy.yaml > pubspec.yaml
rm pubspec_copy.yaml
flutter pub get

#727 introduced a workaround for this. Now the terminate() function that App Store is angry about is guarded by an #ifdef, which by default evaluates to false.

Still getting this on the latest version

The app references non-public selectors in Payload/Runner.app/Frameworks/patrol.framework/patrol: alerts, exists, isHittable, launch, sharedDevice, tap

@jBorkowska

Oh, so that means App Store has broadened its definition of "non-public selectors". We need to get this fixed ASAP. cc @jBorkowska @mateuszwojtczak - this prevents apps that import patrol to be published on App Store.

@jeremiahlukus For now, you can remove the patrol dependency automatically before building a binary that gets uploaded to App Store.

This should be fixed (again) in v1.0.8.

This is still a problem. Yes, we do have a workaround implemented, but we'd like to see it fixed upstream :)

this is fixed in 3.29?
flutter/flutter#161343
https://docs.flutter.dev/release/release-notes/release-notes-3.29.0

upd: nope, 3.30 likely - flutter/flutter#161828

Should this be open? We are experiencing increased build time and size in release app, could it be this or is it fixed in latest patrol version?

@ahlstro

@ahlstro this issue is still open. Only the Flutter issue linked by @emakar is closed.

this should be resolved now in 3.35 with flutter/flutter#160443 (comment)

however, another issue arises - assets from dev_dependencies are included for flutter test, and when running tests with patrol - no dev assets are bundled at all

Navigation Menu

Repository navigation

Patrol is built into a release app, even when it is a dev_dependency #681

(Android) Verify that Patrol's code is built into the app

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Patrol is built into a release app, even when it is a dev_dependency #681

Description

Activity

bartekpacia commented on Dec 19, 2022

(Android) Verify that Patrol's code is built into the app

KonAtPropertyMe commented on Dec 21, 2022

bartekpacia commented on Dec 21, 2022

bartekpacia commented on Jan 12, 2023

jeremiahlukus commented on Mar 15, 2023

bartekpacia commented on Mar 15, 2023

bartekpacia commented on Mar 17, 2023

bartekpacia commented on Apr 3, 2023

emakar commented on Feb 13, 2025

ahlstro commented on Mar 19, 2025

creativecreatorormaybenot commented on Mar 31, 2025

emakar commented on Sep 12, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions