This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Repository navigation
Conversation
bryangingechen
changed the title
bryangingechen
added
the
awaiting-author
jsm28
reviewed
Sep 25, 2020
kbuzzard
reviewed
Sep 25, 2020
Collaborator
|
@lacker I've sent you an invite to create branches in this repo. The advantage of opening PRs from branches in the main mathlib repo is that our CI scripts will generate olean files for each commit and upload them to our Azure server where they can be fetched by |
Contributor
Author
|
Thanks reviewers. I've responded to all items of feedback, please take another look! |
Member
FYI, please change the label from |
jcommelin
added
awaiting-review
jcommelin
reviewed
Sep 29, 2020
urkud
reviewed
Sep 30, 2020
robertylewis
added
awaiting-author
lacker
added
awaiting-review
kim-em
reviewed
Sep 30, 2020
| lemma int_large (a : ℤ) (h : 1 < a) : 1 < a.nat_abs := | ||
| by exact_mod_cast lt_of_lt_of_le h le_nat_abs | ||
|
|
||
| lemma int_not_prime (a b : ℤ) (c : ℕ) (h1 : 1 < a) (h2 : 1 < b) (h3 : a*b = ↑c) : ¬ prime c := |
Collaborator
There was a problem hiding this comment.
Suggested change
| lemma int_not_prime (a b : ℤ) (c : ℕ) (h1 : 1 < a) (h2 : 1 < b) (h3 : a*b = ↑c) : ¬ prime c := | |
| lemma int_not_prime (a b : ℤ) (c : ℕ) (h₁ : 1 < a) (h₂ : 1 < b) (h₃ : a*b = ↑c) : ¬ prime c := |
Just a minor stylistic suggestion, not necessary to adopt. We love our unicode in mathlib. :-) You can type these just as \1, etc.
Collaborator
|
Looks great, thank you! bors d+ |
|
✌️ lacker can now approve this pull request. To approve and merge a pull request, simply reply with |
kim-em
added
delegated
Contributor
Author
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Oct 1, 2020
This is a formalization of the problem and solution for the first problem on the 1969 IMO: Prove that there are infinitely many natural numbers $a$ with the following property: the number $z = n^4 + a$ is not prime for any natural number $n$
|
Pull request successfully merged into master. Build succeeded: |
bors
Bot
changed the title
adomani
pushed a commit
that referenced
this pull request
Oct 7, 2020
This is a formalization of the problem and solution for the first problem on the 1969 IMO: Prove that there are infinitely many natural numbers $a$ with the following property: the number $z = n^4 + a$ is not prime for any natural number $n$
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a formalization of the problem and solution for the first problem on the 1969 IMO:
Prove that there are infinitely many natural numbers$a$ with the following property: the number $z = n^4 + a$ is not prime for any natural number $n$
This is my first submission to mathlib, so please let me know if there are stylistic problems with this, or especially if I'm missing some easier way to do things.