Document return value of uv_get_constrained_memory if no limit is set. - #3753
Merged
Merged
Conversation
maleadt
force-pushed
the
constrained_memory
branch
2 times, most recently
from
September 22, 2022 12:22
d363de5 to
69bbc27
Compare
maleadt
changed the title
maleadt
force-pushed
the
constrained_memory
branch
from
October 26, 2022 10:16
69bbc27 to
4fb16e1
Compare
Contributor
Author
|
Rebased on top of #3754, but apparently I can't change the base to my fork. @bnoordhuis Is this something we want? It seems useful to document what we currently return already for cgroup2's |
maleadt
force-pushed
the
constrained_memory
branch
2 times, most recently
from
October 26, 2022 15:19
f6cfa45 to
d4928c4
Compare
maleadt
force-pushed
the
constrained_memory
branch
from
November 25, 2022 06:58
d4928c4 to
a409cb0
Compare
vtjnash
reviewed
Jan 18, 2023
maleadt
force-pushed
the
constrained_memory
branch
from
January 18, 2023 12:58
a409cb0 to
ccda323
Compare
vtjnash
reviewed
Jan 21, 2023
Also make sure we detect this case for cgroupv1.
maleadt
force-pushed
the
constrained_memory
branch
from
January 23, 2023 10:59
ccda323 to
016b5fe
Compare
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that we return UINT64_MAX if the cgroup limit is set to the
max. For cgroupv2, that happens if we encounter
max, while cgroupv1returns 9223372036854771712 when no limit is set (which according to
this StackExchange discussion is derived from LONG_MAX and
PAGE_SIZE). So make sure we also detect this case for cgroupv1.
Addresses: https://github.com/libuv/libuv/pull/3744/files#r974062912