Repository navigation
Is there an error in Extent.translate ? #3444
Description
In the source code we found:
/** Return this extent moved x and y amounts */
def translate(deltaX: Double, deltaY: Double): Extent =
Extent(
xmin + deltaX,
ymin + deltaY,
xmax + deltaX,
ymin + deltaY
)
Isn't it more like:
/** Return this extent moved x and y amounts */
def translate(deltaX: Double, deltaY: Double): Extent =
Extent(
xmin + deltaX,
ymin + deltaY,
xmax + deltaX,
ymax + deltaY
)
ymax instead of ymin
Activity
pomadchin commentedon Feb 4, 2022
Hey @xvThomas, you're absolutely right! Thx for catching it 🎉 ! Would you like to create a PR + a tiny unit test to trace this bug?
🤦 I guess it was not widely used and that's why we never faced it.