Repository navigation
Convert NODATA ByteConstantTile and ShortConstantCellType: unexpected result #3525
Description
Describe the bug
A NODATA ByteConstantTile that is converted to its own CellType, is no longer NODATA.
To Reproduce
import geotrellis.raster.{ByteConstantTile, byteNODATA}
val t = ByteConstantTile(byteNODATA, cols = 1, rows = 1)
assert(t.isNoDataTile)
assert(t.convert(t.cellType).isNoDataTile) // boomExpected behavior
Seeing as the CellType doesn't change, this should be a no-op and the tile should remain NODATA.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
- Java version: openjdk version "1.8.0_382"
- Scala version: 2.12.15
- GeoTrellis version: 3.6.0
Additional context
Add any other context about the problem here.
Activity
pomadchin commentedon Oct 24, 2023
Thanks for reporting!
There is a bug in the NoData conversion. 👍 nice catch; wondering if any other cellTypes might be affected.
moradology commentedon Oct 25, 2023
Looked into this a small amount yesterday and it appears to be related to
NoDatain particular, so I'd guess this can happen in other contexts. Going to see about addressing this todayConstantTile with nodata: support correct celltype conversion
constanttile fix: changelog update
constanttile fix: docs for new emptyTile method
jdries commentedon Oct 10, 2024
@moradology I did a quick PR, I can expand it a bit further if you believe this general direction is fine.
We'd like to solve this one as it's a fairly important issue for correctness.
constanttile fix: integrate remarks
geotrellis convert for constanttile is broken, add workaround
geotrellis convert for constanttile is broken, add workaround
[-]convert NODATA ByteConstantTile: unexpected result[/-][+]Convert NODATA ByteConstantTile and ShortConstantCellType: unexpected result[/+]ConstantTile with NoData: support idempotent CellType conversions (#3553