Repository navigation
Conversation
Member
|
@lokifacio can you take a look at this and let us know what you think? Thank you! |
Member
Contributor
|
It seems clearer than my solution. Should we include the unit tests I did? |
Member
|
@lokifacio yes, the more testing the better. Would you like to bring those over? You could checkout dwin's repo and cherry pick the test commits or copy the code over, commit, and then create a new PR that would supersede this one. |
Member
|
Superseded by #1601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to supersede #1430. I'll take a look at the merge conflicts this afternoon. I also ran into some issues with the benchmarks. I've been benchmarking with the existing focal benchmarks in
geotrellis-benchmarkusingsbt "geotrellis-benchmark/testOnly benchmark.geotrellis.raster.op.focal.FocalOperationsBenchmark. With my branch published usingscripts/publish-local-crossversion.shthe tests complete with typical results (negligible performance changes relative to what I was seeing on master.) However, with current master the benchmarking suite hangs on:The behavior I'm seeing is that the screen continues to fill up with
.characters indefinitely (left it running for 15 minutes or so before killing.) Once I've resolved the merge conflicts perhaps I'll see the same behavior on my branch.