Repository navigation
Cropped Windowed GeoTiff Reading - #1559
Conversation
| import monocle.syntax.apply._ | ||
| import spire.syntax.cfor._ | ||
|
|
||
| class CompressedBytesArray(compressedBytes: Array[Array[Byte]]) extends CompressedBytes { |
There was a problem hiding this comment.
Naming convention goes from left being the most specific, right being the most general.
Not everything follows this convention in the base library, but we should follow it consistently in this library (and I think we generally do with a couple of exceptions perhaps).
ArrayCompressedBytes
ByteBufferCompressedBytes
would fit better.
Also perhaps a different name would be more descriptive.
SegmentBytes
ArraySegmentBytes
BufferSegmentBytes
Thoughts?
There was a problem hiding this comment.
I agree, those names were just place holders until I could think of something better. I like the names you proposed, and will rename the files and classes with their respective new names.
There was a problem hiding this comment.
Sorry about that, I had begun finishing up the unit tests, but I felt that I was late to make a PR so I just added my code without the tests. I'll be adding the tests soon.
There was a problem hiding this comment.
No worries, just figured I'd mention it explicitly, I know this is a WIP PR :)
|
Should have unit tests around the implementations. |
87e8c5d to
a7becd1
Compare
a7becd1 to
bf26d45
Compare
bf26d45 to
4fdf9f5
Compare
cb81ad7 to
b5b1c92
Compare
b5b1c92 to
0deccb4
Compare
echeipesh
changed the title
Renamed the CompressedBytes abstractions Renamed for real Began writing tests Added unit tests for ArraySegmentBytes Made some changes to ArraySegmentBytes Added BufferSegmentCountsTesting Made changes to BufferSegmentBytes Implemented SegmentBytes in the GeoTiff directory Added map to SegmentBytes and made it work with Writer Modified Boilerplate Changed some of the testing Added some more testing Made chnages Refactored SegmentBytes Added the ability to read in windowed GeoTiffs to the implementations of GeoTiff Refactored toArrayTile Further edits to toArrayTile Corrected toArrayTile Made modifications Implemented the WindowedGeoTiff class in the code Refactored some more Added most of the new Mutables Added windowed reading aslfkjsd Reimplemented the modified mutables Yet even more refactoring Improved testing Added documentation for most things Removed CompressedBytes* files Renamed test Removed BufferSegmentBytes Improved testing made more changes to the tile files. Modified implementation Made more changes to the tests Changed how rows and cols are found
Made change to Float64 Improved testing to meet new implementation Bit complete reformatted tests Added a note on Spec Made a few formatting changes Made changes to sbt for local publishing Made improvements to Windowed Readers speed fixed build.sbt Made striped reading faster for all made some improvements to the reader Made the test a little better Corrected error with the tiled reader7 Updated tests Solved the issue for real this time working on bug fixes
made changes to the striped reader Tiles actually work now. They work for real now Implementation changed Implementation improve and added to all types Cleaned up CroppedGeoTiff Cleaned up code and made a few more changes
Updates tests Removed old Spec Name
Tile reading works without checking now. Changed Int16 and UInt16 Changed formatting Made a few more changes Fixed Tile Reading issue Implemented the correct API Changed how the reading is done in single and mulitband files Made changes to the test Made fromInputStream implicit made some changes to how the buffer is read Made the testing a little better
1e4e407 to
aeaf095
Compare
Removed S3 stuff for good Edited code some more Improved SegmentBytesSpec Edited CroppedWindowedGeoTiffSpec Addd removed file
aeaf095 to
53c3e38
Compare
jbouffard
changed the title
|
@jbouffard can you add a description of the feature in the PR description? Something that if people were to find this PR after the fact, they could understand what the feature being merged in is all about. |
|
@lossyrob Yeah, I just added one. |
|
@lossyrob I looked at where the checked failed, and I don't think it had to do with my code. This is the error message that caused it to fail:
|
Made streaming better
785f3e7 to
b1da186
Compare
|
💯 |
2 participants
This pull request adds the following: