Repository navigation
Example: ShardingKeyIndex[K] - #1633
Merged
Merged
Conversation
fosskers
changed the title
- And made them work. It required some shuffling around of type signatures.
Contributor
Author
|
@lossyrob unit tests pass, with help from @pomadchin and @moradology . My shard prefix algorithm is probably ripe for critique. |
fosskers
commented
Sep 21, 2016
|
|
||
| /* Necessary for extending `KeyIndex` */ | ||
| def keyBounds: KeyBounds[K] = | ||
| inner.keyBounds |
Contributor
Author
There was a problem hiding this comment.
This might be incorrect, and actually prevents us from writing ShardingKeyIndexMethod.
Member
There was a problem hiding this comment.
No, since the Keys are actually completely decoupled from the index side of things, and the shard doesn't effect anything but the index, the keybounds remains valid. So we're good.
fosskers
changed the title
lossyrob
approved these changes
Sep 23, 2016
|
|
||
| /* Necessary for extending `KeyIndex` */ | ||
| def keyBounds: KeyBounds[K] = | ||
| inner.keyBounds |
Member
There was a problem hiding this comment.
No, since the Keys are actually completely decoupled from the index side of things, and the shard doesn't effect anything but the index, the keybounds remains valid. So we're good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
ShardingKeyIndexclassJsonFormatand registratorMotivation
This PR provides an example of how to implement a new
KeyIndexfrom scratch.