Repository navigation
ETL Improvements and other issues fixes - #1647
Merged
Merged
Conversation
Member
Author
|
If clipping by extent and also transforming coordinates, should the clipping frame be specified in the source or target coordinate system? I think it would be more useful in the target coordinate system. In either case some doc would be important to avoid confusion. |
Member
Author
|
@RickMohr in the current implementation - the source coordinate system; though I agree with you, let's make it in target coordinate system and need to update docs, thanks! |
|
Clipping looks good, thanks! |
Member
|
@pomadchin if you just say in the PR body "Fixes #XXX" then it automatically closes them on merge and then I don't have to do it manually ;) |
Member
Author
|
:0 sorry for that @lossyrob |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.