Repository navigation
Added CollectNeighbors - #1859
Merged
lossyrob merged 3 commits intoDec 6, 2016
Merged
Conversation
lossyrob
force-pushed
the
feature/buffer-with-neighbors
branch
from
December 1, 2016 20:58
e39751c to
6199dd4
Compare
Contributor
|
👍 Only comment is a suggestion: In cases like this I increasingly find it handy to nest the enumerating objects like this: sealed trait Direction
object Direction {
case object CenterDirection extends Direction
case object TopDirection extends Direction
case object TopRight extends Direction
case object Right extends Direction
case object BottomRight extends Direction
case object Bottom extends Direction
case object BottomLeft extends Direction
case object Left extends Direction
case object TopLeft extends Direction
}Keeps the silly names down, namespaces the super generic name, which is what I think you're after, and still allows for |
As per @echeipesh review comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows you to connect generic values that are keyed on something with a spatial component.