Repository navigation
Added withDefaultNoData for all DataTypes. - #1966
Merged
Merged
Conversation
Signed-off-by: Simeon H.K. fitch <[email protected]>
Contributor
|
This seems alright, I think we nearly wrote something like this originally but couldn't quite justify it so it was left out. It would be helpful to know what situations specifically prompted this for future understanding and design. |
Member
Author
|
@echeipesh This is where we've run into it: we have a directory structure of GeoTIFF images with different |
Contributor
|
steam checked it, looks good and once again thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simeon H.K. fitch [email protected]
I have run into a number of situations where I'd like to enable the default ConstantNoData value for a DataType when the specific type isn't known at runtime. This PR is a draft implementation for the purposes of getting feedback. If this feature and implementation pass muster, I'll add unit tests.