Repository navigation
Add apply methods to s3rangereader - #1994
Merged
echeipesh merged 1 commit intoJan 31, 2017
Merged
Conversation
Contributor
Author
jbouffard
approved these changes
Jan 30, 2017
echeipesh
approved these changes
Jan 31, 2017
echeipesh
left a comment
echeipesh
left a comment
Contributor
There was a problem hiding this comment.
Looks sensible and using the URI for s3 keys is something we should integrate more consistently. Would be good to see an example of cleanup in the client code this enables.
Contributor
Author
TiffTags read API comparison(Assuming that Before: val s3Uri = new AmazonS3URI(uri)
val s3Client = new AmazonS3Client(new AWSAmazonS3Client(new DefaultAWSCredentialsProviderChain))
val s3RangeReader = S3RangeReader(s3Uri.getBucket, s3Uri.getKey, s3Client)
TiffTagsReader.read(s3RangeReader)After: val s3RangeReader = S3RangeReader(uri)
TiffTagsReader.read(s3RangeReader) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very common use case when using S3 is having to account for URIs and strings. We can use the structure of S3 URIs to make the API for grabbing an
S3RangeReadera little less imposing.