Repository navigation
Loggers serialization safety - #2017
Merged
Merged
Conversation
Signed-off-by: Grigory Pomadchin <[email protected]>
pomadchin
force-pushed
the
fix/spark-persistent
branch
from
February 16, 2017 16:44
9265d3f to
5cb43cb
Compare
Contributor
|
We tested your patch with our code and the Just for the documentation, this was the exception we get when GeoTrellis is using the We could not reproduce this issue in unit tests, too. The NPEs just occur while executing bigger processes with limited memory. |
Member
|
Thanks for looking into that @hjaekel. 👍 |
Contributor
|
I don't think this is a breaking change or even api-change. We replaced a protected field with a protected field. And addition of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though loggers are serializable, we have to be sure that there would be no problems during multiple ser / deser. Spark internal loggers all marked with
@transient, all Hadoop loggers arefinal static. There is still no unit tests related to that issue, though you can notice it during Spark memory shuffle and usingDISK_ONLYorMEMORY_AND_DISKRDD persistence levels.Signed-off-by: Grigory Pomadchin [email protected]