Skip to content

VectorTile: Use latest ScalaPB - #2038

Merged
lossyrob merged 1 commit into
masterfrom
fix/cgw/scalapb
Mar 2, 2017
Merged

lossyrob merged 1 commit into
masterfrom
fix/cgw/scalapb

Conversation

@fosskers

@fosskers fosskers commented Mar 1, 2017

Copy link
Copy Markdown
Contributor

Bumping the dep wasn't enough, the IO code had to be regenerated as well.

Note: The generated code, while marked DO NOT EDIT!, has to be edited to include the license headers and the correct package name, namely geotrellis.vectortile.protobuf.internal.vector_tile.

@fosskers fosskers mentioned this pull request Mar 1, 2017
3 tasks done
@lossyrob
lossyrob merged commit aa60132 into master Mar 2, 2017
@fosskers
fosskers deleted the fix/cgw/scalapb branch March 2, 2017 15:56
@lossyrob lossyrob added this to the 1.1 milestone Mar 12, 2017
@echeipesh

Copy link
Copy Markdown
Contributor

This change to generated code seemed to have been handled safely for minor release

@fosskers

fosskers commented Mar 13, 2017 •

Copy link
Copy Markdown
Contributor Author

Also, the autogenerated code lives in an *.internal package, which by definition is never user facing and so avoids SemVer issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants