Skip to content

Avoid malformed XML in S3 layer deletion - #2040

Merged
echeipesh merged 1 commit into
locationtech:masterfrom
moradology:fix/s3-delete-nonempty-listings
Mar 2, 2017
Merged

echeipesh merged 1 commit into
locationtech:masterfrom
moradology:fix/s3-delete-nonempty-listings

Conversation

@moradology

Copy link
Copy Markdown
Contributor

During failed ingests, metadata will often be written out despite no data having been written for the layer that metadata specifies. The trace such an attempted deletion causes: Exception in thread "main" com.amazonaws.services.s3.model.AmazonS3Exception: The XML you provided was not well-formed or did not validate against our published schema.

By ensuring that S3 deletion requests are only generated for non-empty listings, we avoid this Exception.

During failed ingests, metadata will often be written out despite no
data having been written for the layer that metadata specifies. By
ensuring that S3 deletion requests are only generated for non-empty
listings, we can avoid this Exception.
@moradology moradology changed the title Only attempt deletion when s3 listing is non-empty Avoid malformed XML in S3 layer deletion Mar 2, 2017
@lossyrob lossyrob added this to the 1.0.1 milestone Mar 2, 2017
@echeipesh
echeipesh merged commit a125036 into locationtech:master Mar 2, 2017
@lossyrob lossyrob modified the milestones: 1.1, 1.0.1 Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants