Repository navigation
Repartition in ETL when re-tiling increases layer resolution - #2135
Merged
lossyrob merged 8 commits intoApr 20, 2017
Merged
Conversation
Contributor
Author
Buffered reproject ingest
|
Signed-off-by: Eugene Cheipesh <[email protected]>
Signed-off-by: Eugene Cheipesh <[email protected]>
Signed-off-by: Eugene Cheipesh <[email protected]>
Signed-off-by: Eugene Cheipesh <[email protected]>
Signed-off-by: Eugene Cheipesh <[email protected]>
Signed-off-by: Eugene Cheipesh <[email protected]>
echeipesh
force-pushed
the
fix/upsampling-etl-retile
branch
from
April 11, 2017 04:48
c07af03 to
63a68c4
Compare
pomadchin
reviewed
Apr 11, 2017
| import scala.reflect.ClassTag | ||
|
|
||
| object CutTiles { | ||
| @transient private lazy val logger = LazyLogging(this) |
Member
There was a problem hiding this comment.
Why you don't want to extend LazyLogging? API compatibility? Looks ugly and like we can forget about it ):
Contributor
Author
There was a problem hiding this comment.
Yeah, that was the intent is to avoid adding types to classes when all we want is this private field. I think this should be the prefered approach.
pomadchin
reviewed
Apr 11, 2017
| @@ -29,3 +29,9 @@ trait LazyLogging { | |||
| @transient protected lazy val logger: Logger = | |||
| Logger(LoggerFactory.getLogger(getClass.getName)) | |||
Member
There was a problem hiding this comment.
It you are sure in this approach, LazyLogging(this)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During ETL process there are two ways in which the job specification can cause increase in resolution:
maxZoomparameter forces a higher than necessary level usingZoomedLayoutSchemeLayoutDefinitionis provided that has higher resolution than source imageryThis is possible both in per-tile reprojected and buffered reproject methods.
If the increase in resolution is significant it will dramatically increase the size of the partitions, which were originally mapped to source imagery. Past certain point the partitions become too large to be processed.
For per-tile reproject this PR handles the logic in
geotrellis.spark.etl.Etlclass by inspecting the difference in resolutions of pre-tiled metadata and post-tiled metadata.However in buffered reproject the check must happen during after the reprojection took place. The resolutions in different CRS are not comparable so we must check the tiles covered by the
KeyBounds, assuming that the tiles themselves remain mostly constant in size.Incidental Fixes
Etlmust returnmaxZoomas zoom level when its specifiedResolves: #2129