Repository navigation
Reorganized handling of CellType.name - #2142
Merged
Merged
Conversation
to make it the authoritave representation of cell type, over `toString`. Moved `name` resolution to companion object to make it symmetric with `fromName` implementation. Signed-off-by: Simeon H.K. fitch <[email protected]>
Signed-off-by: Simeon H.K. fitch <[email protected]>
lossyrob
suggested changes
Apr 19, 2017
lossyrob
left a comment
lossyrob
left a comment
Member
There was a problem hiding this comment.
+1 after deprecation string update
| * @param name A string representing a cell type, as reported by [[DataType.name]] e.g. "uint32" | ||
| * @return The CellType corresponding to `name` | ||
| */ | ||
| @deprecated("Use `fromName` instead", "1.2.0") |
lossyrob
approved these changes
Apr 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to make it the authoritative representation of cell type, over
toString.Moved
nameresolution to companion object to make it symmetric withfromNameimplementation.In the previous implementation, inheritance was used as the means of having different values of
nameper type. That caused problems when trying to come up with a general solution based on callingsuperto generate derivatives, since self-types were used over direct inheritance. Having the to/from name handling in the companion also keeps coupled implementations closer to each other.cc: @moradology
Signed-off-by: Simeon H.K. fitch [email protected]