Repository navigation
ValueReaderProvier - #2286
Merged
echeipesh merged 4 commits intoJul 27, 2017
Merged
ValueReaderProvier#2286
Conversation
jpolchlo
suggested changes
Jul 21, 2017
jpolchlo
left a comment
jpolchlo
left a comment
Contributor
There was a problem hiding this comment.
There needs to be some mention of the fact that without a MergeStrategy.concat in the build.sbt of any project that uses the SPI functionality, the META-INF/services/ValueReaderProvider will be overwritten, and not all plugins will be registered. This may affect the build.sbt for spark-etl.
pomadchin
reviewed
Jul 27, 2017
| def valueReader(uri: URI, store: AttributeStore): ValueReader[LayerId] = { | ||
| val _uri = trim(uri) | ||
| val path = new Path(_uri) | ||
| val params = UriUtils.getParams(_uri) |
Member
There was a problem hiding this comment.
For valueReader, layerWriter, attribuetStore
val _uri = trim(uri)
val path = new Path(_uri)
val params = UriUtils.getParams(_uri)Mb that can be sugared?
Contributor
Author
There was a problem hiding this comment.
Not really user functionality, so I wanted to leave it as bare bones as possible
pomadchin
reviewed
Jul 27, 2017
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
Looks fine, only one comment though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2281