Repository navigation
Fix S3GeoTiffRDD behavior with some options. - #2317
Merged
Merged
Conversation
…tition options set.
echeipesh
reviewed
Aug 6, 2017
| options.numPartitions.foreach{ n => S3InputFormat.setPartitionCount(conf, n) } | ||
| options.partitionBytes.foreach{ n => S3InputFormat.setPartitionBytes(conf, n) } | ||
| options.numPartitions.foreach { n => S3InputFormat.setPartitionCount(conf, n) } | ||
| if(options.numPartitions.isEmpty) options.partitionBytes.foreach { n => S3InputFormat.setPartitionBytes(conf, n) } |
Contributor
There was a problem hiding this comment.
Worth a logger.warn about disregarding the partition bytes option.
pomadchin
force-pushed
the
fix/s3if-conditions
branch
2 times, most recently
from
August 6, 2017 19:38
72da164 to
91e22a8
Compare
…iguration options.
pomadchin
force-pushed
the
fix/s3if-conditions
branch
from
August 6, 2017 19:44
91e22a8 to
b354101
Compare
jamesmcclain
reviewed
Aug 7, 2017
jamesmcclain
left a comment
jamesmcclain
left a comment
Member
There was a problem hiding this comment.
This is not a full review, but I can confirm that this resolves the issue reported in #2307
echeipesh
approved these changes
Aug 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed incorrect S3GeoTiffRDD behavior when both partitionBytes & numPattition options set.
Fixes #2307