Skip to content

Added requirement for CRS implementations to provide a readable toString representation. - #2337

Merged
echeipesh merged 3 commits into
locationtech:masterfrom
metasim:printable-crs
Sep 7, 2017
Merged

echeipesh merged 3 commits into
locationtech:masterfrom
metasim:printable-crs

Conversation

@metasim

@metasim metasim commented Aug 19, 2017

Copy link
Copy Markdown
Member

Added implementations for anonymous CRS implementations and singletons.

implementation to ensure that when `toString` is called you don't get
some illegible default `toString` implementation. This is necessary because
`CRS` is a trait that is implemented in many cases by anonomous classes.

Signed-off-by: Simeon H.K. fitch <[email protected]>
Signed-off-by: Simeon H.K. fitch <[email protected]>
@metasim

metasim commented Aug 19, 2017

Copy link
Copy Markdown
Member Author

I could see an argument for not requiring a show implementation (burden on possible third-party implementations). Let me know and I can change the implementation to just specific overrides of toString within GeoTrellis itself.

CRS name as default representation. Maintained use of singleton class
names for predefined CRS values.

Signed-off-by: Simeon H.K. fitch <[email protected]>
@echeipesh
echeipesh merged commit 76032e3 into locationtech:master Sep 7, 2017
@metasim
metasim deleted the printable-crs branch August 24, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants