Repository navigation
Allow rasterizer to store z value at double precision - #2388
Merged
echeipesh merged 2 commits intoSep 20, 2017
Merged
Conversation
moradology
force-pushed
the
feature/double-rasterizer
branch
from
September 19, 2017 20:19
907c288 to
8af0d1e
Compare
Member
|
I think that this was originally the case, but these values were narrowed for economic reasons. |
Contributor
|
Yep, this PR parameterizes it so economy and precision can be served. |
echeipesh
requested changes
Sep 20, 2017
| case class CellValue(value: Double, zindex: Short) | ||
|
|
||
| /** Cell value with its zindex and celltype to be used by the rasterizer. */ | ||
| case class CellValue(value: Double, zindex: Double, celltype: CellType) |
Contributor
There was a problem hiding this comment.
I'm realizing now that the issue was misstated, exposing cellType for zindex per feature actually leads ambiguous behavior: the order in which tiles are merged is undefined and if two priority tiles do not share the same zindex type it is unclear which will be updated and propagated.
So this parameter should be at function invocation level as zindexCellType. Probably ByteConstantNoDataCellType is a nice conservative default value for it.
moradology
force-pushed
the
feature/double-rasterizer
branch
from
September 20, 2017 20:46
26b8e77 to
6c7227f
Compare
Contributor
Author
|
@echeipesh I believe I've addressed the issue you raised - let me know if I'm missing something |
echeipesh
approved these changes
Sep 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows rasterization to store values at double precision (which is immediately useful for elevation rasters) and allows the z values to be stored with a provided
CellType