Repository navigation
Fix out of bound segment index when reading over-buffered GeoTiff window - #2534
Merged
echeipesh merged 2 commits intoJan 3, 2018
Merged
Conversation
echeipesh
force-pushed
the
fix/getIntersectingSegments
branch
from
January 3, 2018 16:20
3f2e4f6 to
d33b392
Compare
6 tasks done
echeipesh
force-pushed
the
fix/getIntersectingSegments
branch
from
January 3, 2018 18:08
8ab0162 to
e0a6205
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
GeoTiffSegmentLayout.getIntersectingSegmentsdid not perform bound checking.As a result if
GridBoundsparameter was outside of the bounds of segment layout an out of bounds index would be returned, resulting in failed segment lookup.This issue was discovered in process of performing buffered window reads: raster-foundry/raster-foundry@49fe952
Checklist
docs/CHANGELOG.rstupdated, if necessarydocsguides update, if necessaryNew user API has useful Scaladoc strings