Skip to content

Fix Inverted Extent - #2812

Merged
echeipesh merged 1 commit into
locationtech:masterfrom
pomadchin:feature/fix-extent
Oct 2, 2018
Merged

echeipesh merged 1 commit into
locationtech:masterfrom
pomadchin:feature/fix-extent

Conversation

@pomadchin

Copy link
Copy Markdown
Member

Overview

This PR allows to handle properly such kinds of Extents:

Corner Coordinates:
Upper Left  (    0.0,    0.0)
Lower Left  (    0.0,13545.0)
Upper Right (21995.0,    0.0)
Lower Right (21995.0,13545.0)
Center      (10997.5, 6772.5)

Closes #2805

@pomadchin pomadchin added this to the 2.1 milestone Oct 1, 2018
@pomadchin
pomadchin requested a review from echeipesh October 1, 2018 14:33
}

Extent(minX, minY, maxX, maxY)
// fix an inverted extent, to behave more like GDAL

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want to perform a silent transform or mb we can throw at least a warning?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that GDAL allows this but seems like a safe conversion here.

@echeipesh
echeipesh merged commit 51a1864 into locationtech:master Oct 2, 2018
@echeipesh

echeipesh commented Oct 2, 2018 •

Copy link
Copy Markdown
Contributor

Backport to 2.1 f0700d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants