Repository navigation
Make IO code agnostic about effects - #2818
Merged
Merged
Conversation
pomadchin
force-pushed
the
feature/agnostic-effects
branch
from
October 19, 2018 11:17
ba78075 to
5721245
Compare
pomadchin
approved these changes
Oct 19, 2018
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
LGTM, a nice pattern that we can use in the entire codebase in the Future. Merging after travis would be happy. Also @moradology fork the updated master branch next time :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change makes
IOBackoffagnostic about the underlying effect engine used by clients at the cost of a slightly more cumbersomecats-effectAPI.I'm curious - @echeipesh @pomadchin - do you guys think this is even worth it?