Repository navigation
Fixes to RasterRegionReproject - #2880
Merged
Merged
Conversation
…e algorithm Signed-off-by: jpolchlo <[email protected]>
Member
|
@jpolchlo Are there any API breaking changes in this PR... if so, having them in the release notes would be helpful for predicting level of effort in future downstream upgrades. |
Member
|
Hey @metasim there are no API changes; precision fixes only. Considered as a ‘bad’ quick fix I suppose ._. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
RasterRegionReproject is a touchy algorithm. Specifically, there is a mock scanline generation algorithm that takes place using a pretty weird geometric intersection algorithm. It is unfortunately useful for speeding up the computation of sampling points, so we're stuck with it. The problem is that the determination of bounds for converting these geometric line segments into a pixel range appears to be numerically touchy. I'm proposing a slight change to the numerical fudge factors that make the process work, but I understand that this is suspicious, and will possibly cause problems depending on the projection of the input points.
We can try to finesse this PR to do something more elegant and more correct through the review process.
Signed-off-by: jpolchlo [email protected]
Checklist
docs/CHANGELOG.rstupdated, if necessarydocsguides update, if necessary