Repository navigation
Bump ScalaPB version up - #2898
Merged
pomadchin merged 6 commits intoApr 26, 2019
Merged
Conversation
pomadchin
commented
Apr 12, 2019
pomadchin
commented
Apr 12, 2019
pomadchin
commented
Apr 12, 2019
pomadchin
force-pushed
the
feature/vectortile-upgrade
branch
from
April 12, 2019 23:57
4da6932 to
fefac62
Compare
jpolchlo
reviewed
Apr 15, 2019
pomadchin
force-pushed
the
feature/vectortile-upgrade
branch
from
April 16, 2019 18:51
d6aa2f8 to
08ec23f
Compare
pomadchin
force-pushed
the
feature/vectortile-upgrade
branch
from
April 25, 2019 18:20
417c53a to
2ed7bf3
Compare
CloudNiner
approved these changes
Apr 25, 2019
CloudNiner
left a comment
CloudNiner
left a comment
Contributor
There was a problem hiding this comment.
normalize changes look fine to me, pending a docstring tweak to explain why the normalize parameter exists.
Contributor
|
👍 |
…, added docstring and parameter into VectorTile constructor functions.
pomadchin
force-pushed
the
feature/vectortile-upgrade
branch
from
April 26, 2019 16:00
6b96493 to
38b70c8
Compare
jpolchlo
reviewed
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates scalapb deps in the vectortile project, removes all generated files from the
srcfolder, starting from this point everything would be generated from this .proto schema on each fresh compilation.Checklist
docsguides update, if necessaryFixes #2909