Repository navigation
Fix map{X|Y}ToGrid function behavior that could give a bit incorrect results - #2953
Merged
Merged
Conversation
pomadchin
changed the title
echeipesh
approved these changes
May 30, 2019
This was referenced Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In case of negative
Extentcoordinates and because of a floating point errors, in case where the north and west site of the block is very close to theIntwe could approximate number of cols / rows incorrectly.Checklist
docs/CHANGELOG.rstupdated, if necessaryCloses #2918