Repository navigation
Conversation
Signed-off-by: Andrey Tararaksin <[email protected]>
pomadchin
force-pushed
the
fix/zoom-ranges-mismatch-on-cog-layer-update
branch
2 times, most recently
from
June 3, 2019 19:27
183feb4 to
e210dcc
Compare
pomadchin
force-pushed
the
fix/zoom-ranges-mismatch-on-cog-layer-update
branch
from
June 3, 2019 19:38
e210dcc to
887b7fa
Compare
pomadchin
approved these changes
Jun 3, 2019
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
LGTM, also thanks for a minor code clean up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes COG layers update behavior to use ZoomRanges that were generated at the time of initial ingest. This prevents possible mismatch.
The PR adds an overload to
COGLayer.fromLayerRDD()which constructs a COGLayer with predefined set of ZoomRanges.Checklist
docs/CHANGELOG.rstupdated, if necessaryNotes
Note that this PR is dependent on #2922, because the test won't succeed unless #2921 is fixed.
Closes #2938