Repository navigation
RangeReader SPI - #2998
Merged
jbouffard merged 1 commit intoJun 18, 2019
Merged
RangeReader SPI#2998
Conversation
pomadchin
approved these changes
Jun 17, 2019
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
LGTM, once travis is happy let's merge it in.
jbouffard
force-pushed
the
feature/range-reader-spi-2
branch
from
June 17, 2019 15:08
791f4b2 to
65228f0
Compare
Signed-off-by: Jacob Bouffard <[email protected]> Implemented RangeReader SPI for hdfs Signed-off-by: Jacob Bouffard <[email protected]> Updated imports Signed-off-by: Jacob Bouffard <[email protected]> Cleaned up code based on review feedback Signed-off-by: Jacob Bouffard <[email protected]> Fix S3Provider specs Cleaned up after cherry picking Signed-off-by: Jacob Bouffard <[email protected]> Updated the CHANGELOG Signed-off-by: Jacob Bouffard <[email protected]> Fixed failing test and general cleanup Signed-off-by: Jacob Bouffard <[email protected]>
jbouffard
force-pushed
the
feature/range-reader-spi-2
branch
from
June 17, 2019 20:11
65228f0 to
52689bb
Compare
pomadchin
reviewed
Jun 18, 2019
| @@ -0,0 +1,9 @@ | |||
| package geotrellis.layers | |||
Member
There was a problem hiding this comment.
It's a shame that I didn't notice this regression. We don't have this subproject anymore. Fixed here #3001
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR supersedes #2977 and it was created in order to avoid a painful rebase.
Checklist
docs/CHANGELOG.rstupdated, if necessarydocsguides update, if necessaryCloses #2940