Repository navigation
Add RasterSources API - #3053
Merged
Merged
Conversation
pomadchin
force-pushed
the
feature/rastersources
branch
from
August 14, 2019 22:15
695a824 to
777c869
Compare
This was referenced Aug 14, 2019
pomadchin
force-pushed
the
feature/rastersources
branch
2 times, most recently
from
August 14, 2019 23:28
91c9556 to
296ac03
Compare
pomadchin
commented
Aug 15, 2019
| .settings(commonSettings) | ||
| .settings(Settings.gdal) | ||
|
|
||
| lazy val `gdal-spark` = project |
Member
Author
There was a problem hiding this comment.
what is the better name / project structure for tests that include tiling, spark and GDAL?
pomadchin
commented
Aug 15, 2019
|
|
||
| import java.io.File | ||
|
|
||
| object GDALTestUtils { |
Member
Author
There was a problem hiding this comment.
Mb the better place for it in a raster-testkit?
pomadchin
commented
Aug 15, 2019
pomadchin
commented
Aug 15, 2019
|
|
||
| expected.dimensions shouldBe actual.dimensions | ||
|
|
||
| assertEqual(expected.crop(gridBounds), actual.tile.crop(gridBounds)) |
Member
Author
There was a problem hiding this comment.
Full rasters comparison is too slow, since it is ~1500x1500 n bands comparison, so I decided to generate a tiny (~250x250) random grid bounds to test it; it added an x10 boost to theese tests (less than 10 seconds instead of more than a minute)
pomadchin
commented
Aug 15, 2019
pomadchin
commented
Aug 15, 2019
metasim
reviewed
Aug 15, 2019
pomadchin
force-pushed
the
feature/rastersources
branch
9 times, most recently
from
August 16, 2019 17:14
6b627fc to
bfb71ad
Compare
pomadchin
force-pushed
the
feature/rastersources
branch
2 times, most recently
from
August 26, 2019 18:50
405a58f to
8e2a0df
Compare
…external overviews support
pomadchin
force-pushed
the
feature/rastersources
branch
3 times, most recently
from
August 26, 2019 21:19
6471123 to
a6dda44
Compare
pomadchin
force-pushed
the
feature/rastersources
branch
from
August 26, 2019 21:23
a6dda44 to
b32fb40
Compare
Its used exclusivly there and avoids introducing another top level class. Potentially it could even be flatterend if not for somewhat confusing prefexing.
The list of Some/None from the case class is otherwise unreadable
We want to allow extending this method for some ill begotten reason, its too restrictive not to do that.
Warning on CellSize downsing are not good enough reason to have a logger in Tile class. This is just too low level and being away of this case is basically expected as baseline knowladge from the users of the library
pomadchin
commented
Aug 28, 2019
| case class GDALRasterSource( | ||
| dataPath: GDALPath, | ||
| options: GDALWarpOptions = GDALWarpOptions.EMPTY, | ||
| class GDALRasterSource( |
Member
Author
There was a problem hiding this comment.
I was using GDALRasterSources without a new keyword. I find it very convinient, mb istead of adding new keyword in tests you can add an overload for convenience? So from the one hand users would be allowed to extend classes, from the other - they will have a handy overload.
pomadchin
commented
Aug 28, 2019
| def convert(targetCellType: CellType): ArrayTile = { | ||
| val tile = ArrayTile.alloc(targetCellType, cols, rows) | ||
|
|
||
| if(targetCellType.isFloatingPoint != cellType.isFloatingPoint) |
Member
Author
There was a problem hiding this comment.
Why have you removed it? I thought that sometimes it is a useful warn O:
pomadchin
force-pushed
the
feature/rastersources
branch
from
September 2, 2019 17:49
9b30f69 to
17ab6f3
Compare
pomadchin
force-pushed
the
feature/rastersources
branch
2 times, most recently
from
September 4, 2019 21:29
c82f011 to
9863b22
Compare
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR moves the code from the https://github.com/geotrellis/geotrellis-contrib repository.
Adds:
All the effects functionality still remains in the contrib repo.
Checklist
docs/CHANGELOG.rstupdated, if necessaryCQs
Closes #2941
Closes #3051
Closes #3054
Closes geotrellis/geotrellis-contrib#233
Closes https://github.com/azavea/geotrellis/issues/160