Repository navigation
Conversation
HttpRangeReader now throws with an HttpStatusException if the server responds with any 4xx or 5xx status code.
echeipesh
approved these changes
Sep 16, 2019
echeipesh
left a comment
echeipesh
left a comment
Contributor
There was a problem hiding this comment.
Test look convincing and this appears to be idiomatic way to do it with scalaj-http
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
HttpRangeReader now throws with an HttpStatusException if the server responds with any 4xx or 5xx status code.
Checklist
docs/CHANGELOG.rstupdated, if necessarydocsguides update, if necessaryNotes
This is a bit more of an expansive fix than specifically just catching 404s, but as far as I can tell, it's correct to catch and throw a helpful error here for any 4xx or 5xx series HTTP error so that the client can handle them properly.
Closes #2791