Repository navigation
Switch to log4s - #3116
Merged
Merged
Switch to log4s#3116
Conversation
Contributor
Author
pomadchin
approved these changes
Oct 4, 2019
1 task done
Member
|
Resolves #3114 but for the master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
GeoTrellis uses
com.typesafe.scalalogging package. This is a popular library but unfortunately theLazyLoggingtrait that is used to mix-in a logger has shifted around a number of timers through the version history. This causes frequent binary incompatibility problems.This PR removes dependency on
typesafe-scalaloggingin favor oflog4sand moves all logging to private members to minimize their leakage.Hopefully this will help us with conflicts and add some nice features to our logging.
Additionally:
GeoWave/GeoMesa do not log errors with experimental notice