Repository navigation
Add Circe codecs for GeoTiffInfo and related classes - #3128
Merged
pomadchin merged 5 commits intoOct 17, 2019
Merged
Conversation
Moving out of GeoTiffReader class. This is a often used class in client code and it makes little sense to tuck it away in a reader.
pomadchin
changed the title
Encoding GeoTiffInfo can be useful for caching purposes. To minimize the implicit resolution time we're tucking away codecs into companion objects and making heavy use of macro encoder/decoder derivation where we can.
echeipesh
force-pushed
the
feature/geotiffinfo-codecs
branch
from
October 16, 2019 22:13
5218e78 to
52b683e
Compare
Move to minimze weirdness in code base. - we don't need another class to hold a function - make private methods private to minmize public API surface - unroll the super weird method extension for tag reading - apply methods should not do reading
echeipesh
force-pushed
the
feature/geotiffinfo-codecs
branch
from
October 17, 2019 01:28
52b683e to
a059d11
Compare
pomadchin
requested changes
Oct 17, 2019
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
LGTM in general, clean and sweet, though requires a couple of fixes.
Also, mb it makes sense to import codes from the extras packages to make them user configurable?
pomadchin
force-pushed
the
feature/geotiffinfo-codecs
branch
2 times, most recently
from
October 17, 2019 20:27
eea171b to
2fa0407
Compare
pomadchin
approved these changes
Oct 17, 2019
pomadchin
left a comment
pomadchin
left a comment
Member
There was a problem hiding this comment.
Done, the reason why codecs are not Configured is because they all need even a default configuration passed everywhere ref. For now, to keep raster package simple, we can go with default codecs and they probably fit 90% of all cases and an implicit configuration will only introduce complexity.
pomadchin
force-pushed
the
feature/geotiffinfo-codecs
branch
from
October 17, 2019 21:06
2fa0407 to
178b866
Compare
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Encoding GeoTiffInfo can be useful for caching purposes. To minimize the implicit resolution time we're tucking away codecs into companion objects and making heavy use of macro encoder/decoder derivation where we can. This is likely going to be needed again in client code and we can save people some pain by just doing it here.
Related: raster-foundry/raster-foundry@0fe73d7
This PR also:
GeoTiffInfoout ofGeoTiffReaderto minimize weirdness in the codebaseTiffTagsReaderclass intoTiffTags.readmethodChecklist
docs/CHANGELOG.rstupdated, if necessary